[BugFix][KVCache] Fix mm hash boundary comparison in get_block_hash_extra_keys#6929
Open
kevincheng2 wants to merge 1 commit intoPaddlePaddle:developfrom
Open
[BugFix][KVCache] Fix mm hash boundary comparison in get_block_hash_extra_keys#6929kevincheng2 wants to merge 1 commit intoPaddlePaddle:developfrom
kevincheng2 wants to merge 1 commit intoPaddlePaddle:developfrom
Conversation
|
chengyanfu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Thanks for your contribution! |
…xtra_keys Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
912d951 to
0afb73a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6929 +/- ##
==========================================
Coverage ? 73.25%
==========================================
Files ? 399
Lines ? 55608
Branches ? 8764
==========================================
Hits ? 40736
Misses ? 11955
Partials ? 2917
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
修复
get_block_hash_extra_keys中多模态图像位置与 block 边界比较的 off-by-one 错误。当图像恰好与 block 相接(image_end == block_start)时,原代码使用<判断导致图像被误判为与 block 有重叠,影响 prefix cache 的 hash 计算正确性。Modifications
image_offset + image_length < start_idx改为<=(2处:快速返回检查和循环内跳过检查)Usage or Command
无需额外配置,修复自动生效。
Checklist
pre-commitbefore commit.🤖 Generated with Claude Code