Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Jan 17, 2026

No description provided.

@Kyle-Ye Kyle-Ye force-pushed the bugfix/foregroundStyle branch from 796a624 to 782ee14 Compare January 17, 2026 18:43
@augmentcode
Copy link

augmentcode bot commented Jan 17, 2026

🤖 Augment PR Summary

Summary: Prevents Color.foregroundStyle from entering a recursive resolution loop when the effective foreground style resolves back to .foreground.

Changes:

  • Adds a recursion-guard flag (`.foreground`) before applying `effectiveForegroundStyle` in ForegroundStyle._apply
  • Makes _ShapeStyle_Shape.effectiveForegroundStyle prefer an explicitly provided foregroundStyle over the environment-derived effective style

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@Kyle-Ye Kyle-Ye changed the title Fix Color.foregroundStyle recursive loop Fix ForegroundStyle recursive loop Jan 17, 2026
@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.13%. Comparing base (a8fe1e8) to head (782ee14).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...SwiftUICore/Shape/ShapeStyle/ForegroundStyle.swift 0.00% 1 Missing ⚠️
...SwiftUICore/Shape/ShapeStyle/ShapeStyleShape.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #730       +/-   ##
===========================================
+ Coverage   14.08%   28.13%   +14.04%     
===========================================
  Files         577      603       +26     
  Lines       34110    36941     +2831     
===========================================
+ Hits         4806    10393     +5587     
+ Misses      29304    26548     -2756     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit a198635 into main Jan 18, 2026
9 of 10 checks passed
@Kyle-Ye Kyle-Ye deleted the bugfix/foregroundStyle branch January 18, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants