Skip to content

Fix signature obtaining in rpm_info probe#2198

Merged
jan-cerny merged 1 commit intoOpenSCAP:maint-1.3from
Xeicker:fix_rpmsignature
Feb 7, 2025
Merged

Fix signature obtaining in rpm_info probe#2198
jan-cerny merged 1 commit intoOpenSCAP:maint-1.3from
Xeicker:fix_rpmsignature

Conversation

@Xeicker
Copy link
Contributor

@Xeicker Xeicker commented Jan 23, 2025

Description

Fix rpminfo probe to correctly obtain signature_keyid in OL9, and possibly RHEL9

Testing

With existing maint1.3 code the key isn't obtained in OL9:

## Executing any rule scan with --oval-results argument
$ ./oscap_wrapper xccdf eval --profile stig --rule xccdf_org.ssgproject.content_rule_set_password_hashing_min_rounds_logindefs --oval-results /usr/share/xml/scap/ssg/content/ssg-ol9-ds.xml
## Check the cpe oval results
$ grep signature_keyid ssg-ol9-cpe-oval.xml.result.xml 
            <lin-sys:signature_keyid>0</lin-sys:signature_keyid>

Applying this change this information is correctly filled:

$ grep signature_keyid ssg-ol9-cpe-oval.xml.result.xml 
            <lin-sys:signature_keyid>bc4d06a08d8b756f</lin-sys:signature_keyid>

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@jan-cerny jan-cerny self-assigned this Feb 7, 2025
Copy link
Member

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me on Fedora as well.

@jan-cerny jan-cerny added this to the 1.3.11 milestone Feb 7, 2025
@jan-cerny jan-cerny merged commit 123e2aa into OpenSCAP:maint-1.3 Feb 7, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants