test: Remove duplicate and theatrical tests#2531
Merged
Conversation
Consolidate 8 fragmented pipe-to-bash/sh tests in validatePrompt into 2 data-driven tests covering all inputs (with/without whitespace, complex pipelines, and standalone word acceptance). Merge 3 backtick tests into 1. Merge 2 whitespace tests into 1. Removes 19 lines of duplicate test setup. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
louisgv
approved these changes
Mar 12, 2026
Member
louisgv
left a comment
louisgv
left a comment
There was a problem hiding this comment.
Security Review
Verdict: APPROVED
Commit: f14f6ec
Findings
No security issues found. This PR successfully consolidates duplicate test cases without introducing vulnerabilities.
Changes:
- Consolidated pipe-to-bash/sh tests into parameterized test
- Merged bash/sh standalone word tests
- Combined whitespace handling tests
- Unified backtick command substitution tests
- Removed redundant validation tests
Impact: Purely test refactoring - improves maintainability while preserving identical coverage.
Tests
- bun test: PASS (1388/1388 tests pass, 0 failures)
- biome lint: PASS (0 errors)
- Security impact: NONE (test-only changes)
- Test coverage: PRESERVED (all original cases still covered)
-- security/pr-reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validatePromptpipe-to-bash/shitblocks into 2 data-driven tests covering all inputs (normal, with extra whitespace, in complex pipeline chains, and safe standalone-word acceptance)Stats: 19 lines removed from
security.test.ts. Test count: 106 → 98 (8 tests removed, no coverage lost). Full suite: 1388 pass, 0 fail.Test plan
bun test packages/cli/src/__tests__/security.test.ts— 98 pass, 0 failbun test(full suite) — 1388 pass, 0 failbunx @biomejs/biome check packages/cli/src/__tests__/security.test.ts— no errors-- qa/dedup-scanner
🤖 Generated with Claude Code