Conversation
leochr
reviewed
Aug 18, 2025
Dockerfile
Outdated
| description="This image contains a sample application that displays the Java system properties and demonstrates MicroProfile Config, Health and Metrics." | ||
|
|
||
| USER 0 | ||
| RUN command -v yum && pkgcmd=yum || pkgcmd=microdnf && $pkgcmd update -y && $pkgcmd install -y procps-ng net-tools ncurses hostname |
Member
There was a problem hiding this comment.
Suggestion: use parentheses to separate the conditions, so it's clear / no ambiguity in the evaluation
Member
Author
There was a problem hiding this comment.
$pkgcmd will lose scope once parenthesized, however the && and || have equal precedence and will be evaluated from left to right. For better readability, I parenthesized the update/install command at the end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This temporarily uses root privilege to install required packages to run the Liberty MustGather (linperf.sh).
It supports Liberty Java images using version 21 (microdnf) and lower (yum).