Skip to content

Conversation

@songmeo
Copy link
Contributor

@songmeo songmeo commented May 16, 2025

addresses #73

Need to rename "specification" to "docs" because gh-pages only pick up /(root) or /docs.

The doc is uploaded to http://opencyphal.github.io/specification/Cyphal_Specification.pdf.

@songmeo songmeo requested a review from pavel-kirienko May 16, 2025 12:05
@songmeo
Copy link
Contributor Author

songmeo commented May 16, 2025

@pavel-kirienko I addressed your comment. The folder is reverted back to specification. I found another option to deploy pages without renaming it. The doc is still uploaded to http://opencyphal.github.io/specification/Cyphal_Specification.pdf like before.

Copy link
Member

@pavel-kirienko pavel-kirienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good

path: '*'
retention-days: 3

- name: Upload GitHub Pages artifact
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Upload GitHub Pages artifact
- name: Publish the specification PDF; the published file is linked by the main website via https://opencyphal.org/specification

@pavel-kirienko pavel-kirienko linked an issue May 16, 2025 that may be closed by this pull request
@pavel-kirienko pavel-kirienko merged commit c8c8655 into master May 16, 2025
2 checks passed
@pavel-kirienko pavel-kirienko deleted the gh-pages branch May 16, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Autopublish

3 participants