feature/TweakedBgGroupAndProviderToken#2729
Merged
simonredfern merged 10 commits intoOpenBankProject:developfrom Mar 11, 2026
Merged
feature/TweakedBgGroupAndProviderToken#2729simonredfern merged 10 commits intoOpenBankProject:developfrom
simonredfern merged 10 commits intoOpenBankProject:developfrom
Conversation
… use BG standard status codes
…re decimal conversion
- Make keystore.path optional to support standard TLS (server-only authentication) - Keep truststore.path mandatory for server certificate verification - Fix truststore.password configuration (was incorrectly using keystore.password) - Update createSSLContext to conditionally load client certificates - Add proper resource cleanup with try-finally blocks - Update error messages to clarify optional vs mandatory SSL properties - Support both mTLS (mutual authentication) and standard TLS (server authentication only)
Renamed misleading idToken parameters to jwtToken in OAuth2.scala OAuth2Util trait. These functions accept both ID Tokens and Access Tokens, so the generic name jwtToken is more accurate. Added clarifying Scaladoc comments explaining the dual-token nature. Changes in OAuth2.scala: - getOrCreateResourceUser(jwtToken) - getOrCreateResourceUserFuture(jwtToken) - resolveProvider(jwtToken) - getOrCreateConsumer(jwtToken, ...) - getClaim(name, jwtToken) Changes in openidconnect.scala: - getOrCreateResourceUser(idToken) - kept as idToken (correctly receives ID Token only) Changes in JwtUtil.scala: - Added getProvider(jwtToken) method for extracting provider claim from tokens All internal variable references and Scaladoc updated accordingly. No logic changes, only parameter renaming for clarity.
hongwei1
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.