Skip to content

[Java][Spring] Insert Annotations to be TYPE_USE Compatible#23207

Draft
Chrimle wants to merge 1 commit intoOpenAPITools:masterfrom
Chrimle:23206-jspecify
Draft

[Java][Spring] Insert Annotations to be TYPE_USE Compatible#23207
Chrimle wants to merge 1 commit intoOpenAPITools:masterfrom
Chrimle:23206-jspecify

Conversation

@Chrimle
Copy link
Contributor

@Chrimle Chrimle commented Mar 11, 2026

WIP WIP WIP
Relates to #23206 .

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Add a test and sample to ensure Java Spring POJOs use TYPE_USE nullability annotations for schema-mapped types, enabling JSpecify compatibility. The test asserts a.b.c.@Nullable PersonCountValue (via importMapping to org.jspecify.annotations.Nullable) instead of @Nullable a.b.c.PersonCountValue (relates to #23206).

Written for commit e05e4a1. Summary will update on new commits.

Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant