[kotlin-server][JAX-RS] Add useTags to kotlin-server JAXRS code generator#22970
[kotlin-server][JAX-RS] Add useTags to kotlin-server JAXRS code generator#22970feczkob wants to merge 6 commits intoOpenAPITools:masterfrom
useTags to kotlin-server JAXRS code generator#22970Conversation
There was a problem hiding this comment.
2 issues found across 10 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="samples/server/petstore/kotlin-server/jaxrs-spec/README.md">
<violation number="1" location="samples/server/petstore/kotlin-server/jaxrs-spec/README.md:37">
P2: README API endpoint table now omits resource prefixes (e.g., /pet, /store, /user), producing incomplete paths and misleading documentation.</violation>
</file>
<file name="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinServerCodegen.java">
<violation number="1" location="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinServerCodegen.java:788">
P2: Default useTags=false is ignored unless the option is explicitly provided, so omitted configuration falls back to tag-based grouping (useTags=true behavior), contradicting the documented default.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
.../openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinServerCodegen.java
Show resolved
Hide resolved
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
|
please resolve the merge conflicts when you've time |
af4d93d to
05b9ba8
Compare
…server-jaxrs-usetags
|
@wing328 thanks for the info, I force pushed with my updated e-mail. Should I regenerate the samples again? I saw some changes in samples seemingly unrelated to my feature, no idea why that was. Thanks for helping me out, this is my first PR here and I can use some guidance 😄 |
Fixes #20342
@karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier @e5l @dennisameling could you please take a look?
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Adds a
useTagsoption to the kotlin-server JAXRS generator to control API grouping/class names and computes acommonPathfor cleaner class-level@Pathand docs. Fixes #20342.New Features
useTags(JAXRS-spec only). When true or not set, group by tags; when false, group by the first path segment.commonPathper API and applies@Path("{{commonPath}}")at the class level; method-level@Pathuses remaining segments. README/docs now show full paths (commonPath+ operation path).Bug Fixes
useTagsis absent (group by tags) and avoids emitting@Path("/")by using an empty path for the root.Written for commit 3ed2af6. Summary will update on new commits.