Add missing Open Packaging Conventions files to NuGet packages#508
Open
salvois wants to merge 1 commit intoOctopusDeploy:mainfrom
Open
Add missing Open Packaging Conventions files to NuGet packages#508salvois wants to merge 1 commit intoOctopusDeploy:mainfrom
salvois wants to merge 1 commit intoOctopusDeploy:mainfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds to .nupkg packages created by
octopus package nuget createfiles required by Open Packaging Conventions, such as:so that the package contains appropriate metadata that is looked for by repositories such as Artifactory.
Fixes #477
This is my first ride with Go, so please excuse me for some rough edges.
I tried to keep the original style and ways of working of the surrounding code, such as writing files to the file system before adding them to the ZIP package, and not escaping values written into XML files, though they may be useful improvements.