-
Notifications
You must be signed in to change notification settings - Fork 9
OCAP 2.0: Modular architecture with database export #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fank
wants to merge
49
commits into
main
Choose a base branch
from
database
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- initial markers exclusion - tbd for remote control firedman - exclude ACE_BFT markers by default - fixes grenades moving to 0,0,0 in playback due to misattribution to liveMissiles PFH
OCAP2/OCAP#37 - adds remote-controlled unit detection if firer was >50m away from initial projectile position OCAP2/OCAP#9 - adds setting for optional BIS_fnc_respawnTickets tracking, will automatically track missionNamespace + faction score counts every 30th frame - adds system for optional custom score tracking by a set of sides, a custom counter separate from BIS_fnc_respawnTickets - pending testing of debug drawIcon for units being recorded remove userconfig
- change MPHit to HitPart - fire tracking, setShotParents - fix debug entityDraw - exclude objects w empty models - fix duplicate fnc_init calls - fix remoteExec diary entries - init at PostInit
- add diary record/pause/save controls for whitelisted admins in CBA setting, or when a user logs in as admin - ensure auto-save respects the saveOnEmpty setting - start recording on autoStart at clientStateNumber 10, or once the mission has actually begun to avoid dead time in recording during briefing screen - don't run init if not multiplayer - fixes duplication EH checking - fixes HandleDisconnect override to prevent unintentional AI taking over DCed players and disrespecting description.ext preferences - skip "__SERVER__ has connected" event
Co-authored-by: jonpas <[email protected]>
- Add requiredVersion = 2.06 to all CfgPatches entries - Fix format string bugs in fnc_metricsLoop.sqf (%2 -> %1) - Fix syntax error in fnc_captureLoop.sqf (comma -> semicolon) - Add lint suppression config for non-critical warnings
- Update extension name from OcapReplaySaver2 to ocap_recorder - Fix params declaration order in ExtensionCallback handler
Logs to RPT: - [OCAP] [EXT] >> outgoing calls (command, args) - [OCAP] [EXT] << responses (result, codes) - [OCAP] [DB-EXT] >> database module calls - [OCAP] [DB-EXT] << database module responses - :VERSION: parsed results
Extension now returns responses in format:
- Success: ["ok", <result>]
- Error: ["error", "<message>"]
Both fnc_sendData functions now:
- Parse response with parseSimpleArray
- Check status ("ok" or "error")
- Return unwrapped result on success
- Log error and return nil on failure
Existing code (e.g., version#0, version#1) continues to work
as the wrapper is now transparent.
- :INIT:DB: → :INIT:STORAGE: - :DB:OK: → :STORAGE:OK: - :DB:ERROR: → :STORAGE:ERROR: Also handle "memory" engine mode with info message.
Remove old extension commands and use unified database path: - :NEW:UNIT: -> :NEW:SOLDIER: - :UPDATE:UNIT: -> :NEW:SOLDIER:STATE: - :NEW:VEH: -> :NEW:VEHICLE: - :UPDATE:VEH: -> :NEW:VEHICLE:STATE: - :EVENT: (hit/kill) -> :HIT:, :KILL: - :FIRED: -> :FIRED: (with extended data) - :MARKER:CREATE: -> :NEW:MARKER: - :MARKER:MOVE: -> :NEW:MARKER:STATE: - :MARKER:DELETE: -> :DELETE:MARKER: - :TIME: -> :NEW:TIME:STATE: - :SAVE: -> :SAVE:MISSION: - Remove :START: and :SET:VERSION: (handled by :NEW:MISSION:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
main/,recorder/,database/,extension/)Test plan