Skip to content

9.0 auth admin passkey#522

Closed
rvalyi wants to merge 2 commits intoOCA:9.0from
akretion:9.0-auth_admin_passkey
Closed

9.0 auth admin passkey#522
rvalyi wants to merge 2 commits intoOCA:9.0from
akretion:9.0-auth_admin_passkey

Conversation

@rvalyi
Copy link
Member

@rvalyi rvalyi commented Aug 18, 2016

same as 8.0 #519
but also migrated the view and enable the module on 9.0
cc @legalsylvain @pedrobaeza

@pedrobaeza
Copy link
Member

pedrobaeza commented Aug 18, 2016

Please change module version to 9.0.1.0.0.

This was referenced Aug 18, 2016
Closed
Closed
@pedrobaeza
Copy link
Member

pedrobaeza commented Aug 18, 2016

See the comments in 8.0 version.

@pedrobaeza pedrobaeza mentioned this pull request Aug 23, 2016
Closed
lasley
lasley reviewed Aug 23, 2016
View reviewed changes
auth_admin_passkey/__openerp__.py
@@ -41,6 +24,6 @@
'images': [],
'post_load': '',
Copy link
Contributor

@lasley lasley Aug 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove empty keys

@rvalyi
Copy link
Member Author

rvalyi commented Aug 23, 2016 •
edited
Loading

@lasley @JayVora-SerpentCS thanks for the review. Guys I'll apply these changes on #519 for the remaining ones and then cherry-pick and amend the commit from 8.0 here. cc @legalsylvain . Once I started making changes in the 8.0 PR I put the "work in progress" label on this 9.0 PR, I'm sorry if that wasn't clear.

@pedrobaeza
Copy link
Member

pedrobaeza commented Nov 22, 2016

I have merged the other PR. Please include the changes and attend comments here.

@nicomacr nicomacr mentioned this pull request Dec 29, 2016
Closed
@pedrobaeza pedrobaeza mentioned this pull request Jan 25, 2017
Closed
@JonathanNEMRY
Copy link

JonathanNEMRY commented Feb 23, 2017

I think this branche should be "rebase" to be complient with the last commit 601109e . Moreover, what's the current status of this one?

JonathanNEMRY pushed a commit to acsone/server-tools that referenced this pull request Feb 23, 2017
[CHG] review of OCA#522 & add setup for auth_admin
5802b96
JonathanNEMRY pushed a commit to acsone/server-tools that referenced this pull request Feb 23, 2017
[CHG] review of OCA#522 & add setup for auth_admin
4ea9b7a
JonathanNEMRY pushed a commit to acsone/server-tools that referenced this pull request Feb 23, 2017
[CHG] review of OCA#522 & add setup for auth_admin
cc5a8b9
@JonathanNEMRY
Copy link

JonathanNEMRY commented Feb 23, 2017

I finally applied changes into akretion#14 & akretion#15 Once @rvalyi merged 15 and 14 I think this one will be ok to be merged into oca/9.0

@JonathanNEMRY JonathanNEMRY mentioned this pull request Mar 29, 2017
Merged
@pedrobaeza
Copy link
Member

pedrobaeza commented Dec 7, 2018

@rvalyi this one is conflicting. Are you going to finish this?

@github-actions
Copy link

github-actions bot commented Feb 6, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JonathanNEMRY JonathanNEMRY JonathanNEMRY left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically. work in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rvalyi @pedrobaeza @JonathanNEMRY @JayVora-SerpentCS @lasley