[FIX] mock.patch(auto_spec=True) does not exist#898
Merged
OCA-git-bot merged 1 commit intoOCA:18.0from Feb 20, 2026
Merged
Conversation
There is no parameter auto_spec to mock.patch. This is likely a typo.
Running the tests with Python 3.12 give a RuntimeError
```
File "/usr/local/lib/python3.12/unittest/mock.py", line 1311, in __init__
_check_spec_arg_typos(kwargs)
File "/usr/local/lib/python3.12/unittest/mock.py", line 1287, in _check_spec_arg_typos
raise RuntimeError(
RuntimeError: 'auto_spec' might be a typo.
```
Contributor
amh-mw
suggested changes
Feb 19, 2026
| with mock.patch( | ||
| "odoo.addons.queue_job.delay.Job", | ||
| name="Job Class", | ||
| auto_spec=True, |
Member
There was a problem hiding this comment.
Per https://docs.python.org/3/library/unittest.mock.html#auto-speccing?
- auto_spec=True,
+ autospec=True,
Member
Author
There was a problem hiding this comment.
yes, I thought about that too. The thing is that auto_spec never did anything, and things have been working so far, which is why I'm tempted to just remove the kwarg.
Member
Author
There was a problem hiding this comment.
and removing it does not break the tests...
sbidoul
approved these changes
Feb 19, 2026
amh-mw
approved these changes
Feb 19, 2026
Member
Author
|
I will backport this. |
This was referenced Feb 20, 2026
guewen
approved these changes
Feb 20, 2026
Member
|
/ocabot merge nobump |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 2601ebb. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no parameter auto_spec to mock.patch. This is likely a typo.
Running the tests with Python 3.12 give a RuntimeError