Skip to content

schema-publish: Use commit date instead of author date#5229

Open
ralfhandl wants to merge 1 commit intoOAI:mainfrom
ralfhandl:main-schema-publish-improved-console-output
Open

schema-publish: Use commit date instead of author date#5229
ralfhandl wants to merge 1 commit intoOAI:mainfrom
ralfhandl:main-schema-publish-improved-console-output

Conversation

@ralfhandl
Copy link
Contributor

  • Use commit date of last change to construct schema file names instead of author date
    • the date a change was merged into the spec version dev branch is easier to track/understand than the date the author made that change in their local repo
  • Improve console output of what happened why

  • no schema changes are needed for this pull request

and improve trace of what happened
@karenetheridge
Copy link
Member

This should be today's date (the date that the schemas are published), not the date of the most recent merge.

@ralfhandl
Copy link
Contributor Author

This should be today's date (the date that the schemas are published), not the date of the most recent merge.

There are four schema files, and so far we only create a new iteration of a file if

  • its source changes, or
  • one of its dependencies changes.

Then we use the date of that change as the iteration name.

This minimises the number of iterations:

  • If schema.yaml changes, only schema and schema-base get new iterations with the same date.
  • If meta.yaml changes, all four files get new iterations with the same date.

This PR keeps that logic and only picks a "better" change date - the commit date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants