Always register custom singularity oredict recipes#32
Open
WaitingIdly wants to merge 1 commit intoNomifactory:masterfrom
Open
Always register custom singularity oredict recipes#32WaitingIdly wants to merge 1 commit intoNomifactory:masterfrom
WaitingIdly wants to merge 1 commit intoNomifactory:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #31
because fba62b6 moved registering custom singularity recipes into preInit, any oredict created afterwards (eg crafttweaker) wouldnt register a singularity due to over-cautious validation checks. however, if a singularity is registered to an oredict that doesnt exist/has no items: nothing bad happens. in fact, this happens by default in
ItemSingularity.java, since it tries to register a singularity toingotArdite, and the dev environment doesnt have anyingotArdite.as such, this PR changes
ItemSingularityCustom.javato always register oredict singularities, even when the oredict doesnt exist or has no items.tested with
S:custom_singularities < 101;experience;ore:itemXP;b3f43b >and both with and without