-
Notifications
You must be signed in to change notification settings - Fork 8
Add Nodes for Opening and Closing Projects #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update:
- README.md: Please add docstring for the new nodes
- CHANGELOG.md: Please add a changelog entry for this change
- pyproject.toml: Please update the version to 1.1.0
Other than that I've added a couple of comments inline.
Lastly, please just run .\repo.bat format to make sure all the changes are formatted properly and SQUASH all your commits into a single commit :)
po-trottier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just added a few cleanup comments but LGTM otherwise!
|
With the most recent change you'll need to update both the regular and LowVRAM templates to update the ingestion nodes and provide the output dir since it's now explicitly required :P |
f383c7f to
4dae638
Compare
Added some more project workflow management to RTX Remix nodes to handle execution flow. Mainly to save VRAM for AI processing that remix is taking up in viewport.
New Features:
• Open Project Node - Opens RTX Remix projects by layer ID
• Get Loaded Project - Gets layer ID of current open project for Open Project node to use later
• Close Project Node - Closes RTX Remix projects
• Get Default Directory Node - Captures the RTX Remix default output directory before closing projects
• Edited Ingest Texture Node - Made Optional Output_folder mandatory, provided by user or Get Default Direcotry Node
• Fixed Path handling compatibility for URLs with spaces when calling toolkit
• Added a PBRify workflow "rtx_remix_pbrify_workflow_LowVRAM" showing this at work and for users with low vram
• Edited normal PBRify workflow to work with new ingest texture changes
Tested on latest comfyui build