feat: implement external secret resolver for L7 network policies#539
Closed
tatsuya-ogawa wants to merge 7 commits intoNVIDIA:mainfrom
Closed
feat: implement external secret resolver for L7 network policies#539tatsuya-ogawa wants to merge 7 commits intoNVIDIA:mainfrom
tatsuya-ogawa wants to merge 7 commits intoNVIDIA:mainfrom
Conversation
|
Thank you for your interest in contributing to OpenShell, @tatsuya-ogawa. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the OpenShell sandbox's L7 relay only supports static secrets or environment variable placeholders resolved at startup. To support environments where secrets are dynamic or managed by external systems (e.g., rotating tokens, vault services, or identity-based access), a more flexible resolution mechanism is required.
This PR introduces the External Resolver, allowing the sandbox to fetch credentials on-demand from an HTTP endpoint right before relaying a request to an upstream provider. This enhances security by moving secret management out of the sandbox configuration and into dedicated infrastructure.
Related Issue
#538
Changes
Header Injection: Updated the REST protocol provider to inject resolved secrets into specific request headers (e.g., Authorization: Bearer ) based on the resolver's instructions.
Testing
mise run pre-commitpassesChecklist