Add support for multiple nodes#95
Merged
martialblog merged 3 commits intorelease/v1-0-0from Feb 11, 2026
Merged
Conversation
This changes the --hostname flag into an array of strings so that it can be used multiple this. It also removes the --tls and --port flag which are now included as a full URL in the --hostname
9e15dc8 to
eeae35b
Compare
Member
|
I do like the functionality and in general I do approve of this. |
Member
Author
|
Yes indeed, I will note that in the Release Notes and we should state it in the packages. On the other side, I do think plugin is pretty feature complete after my recent changes and we could move to a 1.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the --hostname flag into an array of strings so that it can be used multiple this.
It also removes the --tls and --port flag which are now included as a full URL in the --hostname.
And the CHECK_ELASTICSEARCH_HOSTNAME env variable is removed, since it was designed for a single hostname.
Some examples:
With multiple nodes:
When one node is down (I have no indices so all is green, note the nodes=2):
When no node is reachable: