Skip to content

Take advantage of the refactored ANIMartRIX to call the new _base met…#345

Open
netmindz wants to merge 1 commit intoMoonModules:mdevfrom
netmindz:ANIMartRIX-configurable
Open

Take advantage of the refactored ANIMartRIX to call the new _base met…#345
netmindz wants to merge 1 commit intoMoonModules:mdevfrom
netmindz:ANIMartRIX-configurable

Conversation

@netmindz
Copy link
Collaborator

@netmindz netmindz commented Mar 7, 2026

…hods with varying parameters at runtime

Summary by CodeRabbit

  • New Features

    • Enhanced animation modes with additional customization parameters (width, scale, zoom, distance offsets).
    • Consolidated multiple animation effects for improved consistency and control.
  • Chores

    • Updated Animartrix library dependency to latest version.

@netmindz netmindz requested a review from softhack007 March 7, 2026 15:05
@coderabbitai
Copy link

coderabbitai bot commented Mar 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 31fa1d76-fca1-4e55-8d06-08d24b0b6169

📥 Commits

Reviewing files that changed from the base of the PR and between 32bc474 and be5ce80.

📒 Files selected for processing (2)
  • platformio.ini
  • usermods/usermod_v2_animartrix/usermod_v2_animartrix.h

📝 Walkthrough

Walkthrough

The PR updates the animartrix library dependency to a newer commit and refactors the animartrix usermod by consolidating multiple animation modes into parameterized variants. Several standalone mode functions are combined with shared implementations, a helper mapping function is introduced, and effect registrations are updated accordingly.

Changes

Cohort / File(s) Summary
Library Dependency
platformio.ini
Updated animartrix library commit hash from 81eb09b to 932337e.
Animation Modes Consolidation & Parameterization
usermods/usermod_v2_animartrix/usermod_v2_animartrix.h
Consolidated 10 separate animation modes into 6 parameterized variants (e.g., mode_Module_Experiment10 → mode_Module_Experiment810; mode_SM10/SM9 → mode_SM910). Added animartrix_mapf helper for parameter mapping. Updated mode implementations to compute parameters from SEGMENT values and updated effect registrations to reflect new mode names and data constants. Net change: +63/-84 lines.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

🐰 Modes consolidate, parameters flow free,
Ten become six through harmony,
A mapping helper guides the way,
Animartrix shines brighter today!
~CodeRabbit's fuzzy refactoring praise 🎨✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 10.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main objective: updating code to leverage refactored ANIMartRIX _base methods called with runtime parameters.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant