Skip to content

feat: Quiet Mode for certain game types#4096

Open
MrGadget1024 wants to merge 2 commits intomasterfrom
QuietMode
Open

feat: Quiet Mode for certain game types#4096
MrGadget1024 wants to merge 2 commits intomasterfrom
QuietMode

Conversation

@MrGadget1024
Copy link
Collaborator

@MrGadget1024 MrGadget1024 commented Feb 27, 2026

Network Manager now has a checkbox to enable Quiet Mode

  • Disables TimeSnapshotMessage entirely
  • Forces PingMessage frequency to 0.5Hz (2 sec interval)
  • Only for games NOT using NT or PredictedRB (warnings included)
  • Unit tests updated accordingly
image

Network Manager now has a checkbox to enable Quiet Mode
- Disables TimeSnapshotMessage entirely
- Forces PingMessage frequency to 0.5Hz (2 sec interval)
- Only for games NOT using NT or PredictedRB (warnings included)
- Unit tests updated accordingly
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.71%. Comparing base (ef974ba) to head (5f83156).

Files with missing lines Patch % Lines
...omponents/PredictedRigidbody/PredictedRigidbody.cs 0.00% 4 Missing ⚠️
...omponents/NetworkTransform/NetworkTransformBase.cs 0.00% 2 Missing ⚠️
Assets/Mirror/Core/NetworkClient.cs 0.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4096      +/-   ##
==========================================
- Coverage   42.71%   42.71%   -0.01%     
==========================================
  Files         150      150              
  Lines       14623    14635      +12     
==========================================
+ Hits         6246     6251       +5     
- Misses       8377     8384       +7     
Flag Coverage Δ
unittests 42.71% <50.00%> (-0.01%) ⬇️
unity-6000.3.2f1 42.71% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
Assets/Mirror/Core/NetworkManager.cs 42.06% <100.00%> (+0.20%) ⬆️
Assets/Mirror/Core/NetworkServer.cs 68.64% <100.00%> (+0.03%) ⬆️
Assets/Mirror/Core/NetworkTime.cs 90.38% <100.00%> (+0.38%) ⬆️
...omponents/NetworkTransform/NetworkTransformBase.cs 40.00% <0.00%> (-0.47%) ⬇️
Assets/Mirror/Core/NetworkClient.cs 83.24% <0.00%> (-0.09%) ⬇️
...omponents/PredictedRigidbody/PredictedRigidbody.cs 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@miwarnec
Copy link
Collaborator

miwarnec commented Mar 1, 2026

this is too hardcoded / arbitrary.
let's just make it a setting and let the user decide

@MrGadget1024
Copy link
Collaborator Author

this is too hardcoded / arbitrary. let's just make it a setting and let the user decide

IT IS A SETTING IN NETWORK MANAGER!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting Review enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants