Open
Conversation
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Alexandre NICOLAIE <xunleii@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thanks for this project! I'm really looking forward to testing it out properly. Since I currently only have access to Gemini (and GitHub Copilot), I decided to implement the Gemini integration myself to get things moving.
Gemini CLI Provider Integration:
GeminiProviderininternal/agent/gemini.goto interface with the Gemini CLI, including methods for command construction, output parsing, and log file naming.GeminiProviderininternal/agent/gemini_test.go.internal/agent/resolve.goto support"gemini"as a valid provider and improved error messages for unknown providers.internal/agent/resolve_test.go. [1] [2]Gemini Stream Event Parsing:
internal/loop/gemini_parser.gowith a parser for Gemini'sstream-jsonoutput, mapping Gemini events to Chief's internal event types.internal/loop/gemini_parser_test.go.Documentation and Configuration Updates:
README.md,docs/reference/configuration.md) and CLI help text to list Gemini as a supported agent provider and clarify configuration options. [1] [2] [3] [4] [5] [6]These changes make it possible to use the Gemini CLI as a drop-in agent for Chief, with full support for configuration, event handling, and output processing.
Note
Current Status: Full vibe coding mode with a quick review on my end.
Looks solid—it works with Gemini CLI, so I'm good to go. Successfully built a short Python app with it
Fixes #56