This repository was archived by the owner on Sep 25, 2019. It is now read-only.
Conversation
Rails 3.2 has been released a while ago and it brings some benefits during development and other improvements. Also other gems have received new features and bug-fixes. Since the test-coverage of anduin is quite high, I consider it safe to upgrade and fix the failing tests.
As stated by the devise documentation, this is no longer advised: > Devise.use_salt_as_remember_token is false which is no longer > supported. Devise now only uses the salt as remember token and > the remember_token column can be removed from your models.
This fixes two warnings during initialisation. Seems pdf and png are now already being registered within rails.
passing in the format in the filename is deprecated and so a warning was raised. This is now gone.
Some strings changed, this is the new version of this file as generated by `rails g devise:install`.
The form for the sign in process is named new_user instead of user_new, now. Therefor the step definitions needed to be adjusted. Everything passing fine, again.
ghost
assigned
2.0.7 has a bug, that is fixed in current master, but without a release. This bug makes it unusable with ruby 1.8. This can be removed, once the bug-fixed version is released.
Member
Author
|
After commiting another hot-fix for ruby 1.8, this is working fine now on anduintest.metameute.de. Anyway. Before really merging this, I want to wait until a new version of twitter-bootstrap-rails is released, that fixes the ruby 1.8-issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I upgraded rails to 3.2. Will deploy it to anduintest.metameute.de and check if everything still runs fine.