fix(ci): cache and install Playwright browsers in e2e job#844
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tall Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
c346e26 to
7874d1c
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Coverage Report
File CoverageNo changed files found. |
sirtimid
approved these changes
Feb 19, 2026
rekmarks
added a commit
that referenced
this pull request
Feb 20, 2026
The `test` job was logging a Playwright \"Executable doesn't exist\" error (the same root cause fixed for the `e2e` job in #844): the `prepare` job caches `node_modules` while the postinstall script skips browser downloads in CI, so when downstream jobs restore from cache, Playwright browsers are never downloaded. ## Changes - Add `.github/actions/playwright-install` composite action that caches `~/.cache/ms-playwright` (keyed on OS + `yarn.lock`) and installs Playwright Chromium with `--with-deps` on cache miss, or just `install-deps` on cache hit; use it in both the `test` and `e2e` jobs - Simplify `scripts/playwright-install.sh` to check `$CI` (always `true` in GitHub Actions) instead of `PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD`, removing the need to set that env var in every job and the now-redundant Dependabot check (Dependabot runs in CI) - Always use `--with-deps` in `playwright-install.sh`, removing the dead `PLAYWRIGHT_ONLY_SHELL` and CI-branch logic ## Testing CI-only change. Verified by pushing and confirming both `Test` and `E2E Tests` jobs install Playwright browsers correctly. The two jobs share the same cache key, so only one download occurs per `yarn.lock` hash. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
e2eCI job was failing on #843 with "Executable doesn't exist" for the Playwright Chromium binary. The root cause: thepreparejob installs dependencies withPLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1and cachesnode_modules. When thee2ejob restores that cache,yarn installis skipped entirely, sopostinstall/playwright-install.shnever runs and the browsers are never downloaded. Playwright browsers live in~/.cache/ms-playwright/, not innode_modules, so they are not covered by the node_modules cache.Changes
actions/cache) to thee2ejob, keyed onrunner.os+yarn.lockhash so it automatically invalidates when Playwright is updated.yarn playwright install chromiumonly on a cache miss, and always installs Playwright dependencies, which are not cached.Testing
This is a CI configuration change. It is verified by pushing the branch and confirming the
E2E Tests / omnium-gatherum(and sibling matrix) jobs pass. On the first run the cache will miss and download Chromium; subsequent runs with the sameyarn.lockwill hit the cache and skip the download.Note
Low Risk
CI/workflow and dependency-version updates only; main risk is longer first-run CI times or cache-key issues affecting E2E job reliability.
Overview
Prevents E2E CI failures caused by missing Playwright Chromium binaries when
node_modulesis restored from cache and Playwrightpostinstalldoesn’t run.Updates the
e2eGitHub Actions job to cache~/.cache/ms-playwright(keyed by OS +yarn.lock) and to install Playwright Chromium on cache miss, plus always install required system deps viaplaywright install-deps.Bumps Playwright tooling to
^1.58.2across the repo (rootplaywrightdevDependency and workspace@playwright/test/playwrightversions), updatingyarn.lockaccordingly.Written by Cursor Bugbot for commit fb33ca9. This will update automatically on new commits. Configure here.