Skip to content

chore(controller-utils): replace Sinon with Jest fake timers#7967

Merged
cryptodev-2s merged 1 commit intomainfrom
chore/controller-utils-replace-sinon-with-jest
Feb 18, 2026
Merged

chore(controller-utils): replace Sinon with Jest fake timers#7967
cryptodev-2s merged 1 commit intomainfrom
chore/controller-utils-replace-sinon-with-jest

Conversation

@cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Feb 17, 2026

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Test-only timer refactor plus dependency removal; minimal risk beyond potential fake-timer behavior differences affecting test reliability.

Overview
Updates create-service-policy.test.ts to stop using Sinon fake timers and instead use Jest’s fake timers (jest.useFakeTimers, advanceTimersByTime, runAllTimersAsync, advanceTimersToNextTimer, etc.), including opting out of faking nextTick/queueMicrotask.

Removes the sinon devDependency from @metamask/controller-utils (and yarn.lock) since it’s no longer needed.

Written by Cursor Bugbot for commit 9015111. This will update automatically on new commits. Configure here.

@cryptodev-2s cryptodev-2s self-assigned this Feb 17, 2026
@cryptodev-2s cryptodev-2s requested a review from a team as a code owner February 17, 2026 21:40
@cryptodev-2s cryptodev-2s added this pull request to the merge queue Feb 18, 2026
Merged via the queue into main with commit 9f588fa Feb 18, 2026
308 checks passed
@cryptodev-2s cryptodev-2s deleted the chore/controller-utils-replace-sinon-with-jest branch February 18, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants