chore(transaction-controller): replace Sinon with Jest fake timers

[cryptodev-2s]

Explanation

References

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

---

Note

Low Risk
Test-only timer/mocking changes plus a devDependency removal; production code paths are unaffected, with main risk limited to subtle fake-timer behavioral differences causing flaky tests.

Overview
Switches transaction-controller tests that depended on Sinon clocks over to Jest fake timers, replacing useFakeTimers/clock.tickAsync usage with jest.useFakeTimers/jestAdvanceTime.

Adds a shared jestAdvanceTime helper in tests/helpers.ts (stepwise async timer advancement) and drops sinon from @metamask/transaction-controller devDependencies (and yarn.lock).

^{Written by Cursor Bugbot for commit c07803e. This will update automatically on new commits. Configure here.}