Open
Conversation
Member
Author
|
The gitlab ci changes seem unnecessary. But the strict build changes seem useful? |
7bb67e5 to
4703a36
Compare
Member
Author
|
I've removed the commit for the gitlab yaml file. But I've kept these strict build changes. Please review @nzhang-zh and see if they should be merged. Also are strict code being checked by the CI? |
Member
Author
|
Now that we 2 "main" branches: master and postgres. After merging into master, these changes must be synced postgres branch. Probably via cherry picking. |
Member
Author
|
This has some relationship with #28? |
Member
Author
|
This failed hlint and brittany. Hlint should be fixed easily. The brittany failure is a mystery. Not sure why that is happening. |
Contributor
|
The gitlab ci changes are obsoleted by #26 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw this branch was being used before... but it was never merged. Quite strange?