Enable/Disable Hex mode: modify User preference, not Workspace

[malsyned]

Fixes #1107

[haneefdm]

Rejected. Sorry. All our settings will work the same way.. If you want your team to behave a certain way, that is on you. I don't even want to go into explaining to everyone why certain settings works one way vs others.

[haneefdm]

Oh, I see what you did. It is still a problem and have to think of a better solution

[malsyned]

All our settings will work the same way

This isn't quite true. This setting works differently from every other setting, because this setting is modified by code within the cortex-debug extension.

I agree, there's not really any solution to this that's both good and simple. In my opinion, if you have to hard-code the location where the setting is changed, user settings are better than workspace settings. But not hard-coding it is better still.

It's possible to use the inspect() method to find out if there's already a setting for this somewhere and to change it in that location if so. If I send in a PR that works that way, and defaults to modifying the user's global settings if it isn't set anywhere, would you be interested in merging that?

[haneefdm]

It's possible to use the inspect() method to find out if there's already a setting for this somewhere and to change it in that location if so. If I send in a PR that works that way, and defaults to modifying the user's global settings if it isn't set anywhere, would you be interested in merging that?

Yes, I would be interested in that.. That would be much better Besides, if the user had it at WS or Folder and we are only modifying the Global setting, it would not have worked anyways.

• If the user had a setting for a specific scope, modify that one
• If not, set it at Global scope.

It is unfortunate this setting works this way. Also, when this code was written, the update/inspect did not have all these options. Even the concept of a WS did not exist or was brand new and had many issues.

[malsyned]

OK awesome, I should have something for you later today.

[malsyned]

I'm closing this pull request, it's superseded by #1109 which implements the more complicated behavior we discussed here.