Fix path normalization on windows.#1095
Merged
haneefdm merged 3 commits intoMarus:masterfrom Mar 29, 2025
Merged
Conversation
Contributor
Author
haneefdm
reviewed
Mar 27, 2025
src/gdb.ts
Outdated
|
|
||
| if (args.executable && !path.isAbsolute(args.executable)) { | ||
| args.executable = path.normalize(path.join(args.cwd, args.executable)); | ||
| if(os.platform().startsWith("win")){ |
Collaborator
There was a problem hiding this comment.
Why the .startsWith. Why not compare it to 'win32'. That is officially what it is. Also make sure you run 'npm run lint'
Collaborator
Contributor
Author
|
@haneefdm Will do tonight. Thanks for the pointers i didnt know that win32 was official and win64 doesnt exist. |
Contributor
Author
|
@haneefdm I fixed the issues, sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
path.normalize()function returns a path with the\\on windows. so i did a check after the normalize to replace the\\if the platform is windows.