Skip to content

Conversation

@rfcbf
Copy link
Contributor

@rfcbf rfcbf commented Dec 15, 2025

Description

include web view from instagram

Type of Change

  • 🎉 feat: New feature
  • 🐛 fix: Bug fix
  • 📝 docs: Documentation update
  • 💄 style: Code style/formatting changes
  • ♻️ refactor: Code refactoring
  • perf: Performance improvement
  • test: Adding or updating tests
  • 🔧 chore: Maintenance tasks
  • 🏗️ build: Build system changes
  • 👷 ci: CI configuration changes

Related Issue

Screenshots/Videos

Testing

  • Tested on iPhone (specify model/iOS version):
  • Tested on iPad (specify model/iOS version):
  • All unit tests pass
  • No SwiftLint warnings/errors

Checklist

  • My code follows the project's code style
  • I have performed a self-review of my code
  • I have commented my code where necessary
  • I have updated the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My branch is up-to-date with the base branch

Additional Notes

Implements a WebView-based Instagram feed in the social section.

This feature provides users with access to the Instagram feed within the app. It handles loading states and errors gracefully, displaying a placeholder view when content is unavailable. It also configures the scroll behavior based on device type to correctly display the content on both iPad and iPhone. Furthermore, the feature enables opening Instagram URLs, either within the app or by redirecting to the Instagram app, if installed.

The feature is behind a check to ensure if the content is available.
Replaces the previous Instagram integration with a `WebView` to improve stability and address potential issues with the older implementation.

The `InstagramContainerView` is removed and `SocialView` is updated to use the new `InstagramPostsWebView` directly. This change ensures a more consistent and reliable user experience when viewing Instagram content within the app.

The `MMGrey6` color definition is updated to use explicit srgb color values instead of a system reference.
Updates MMGrey6 color to utilize the system provided gray 6 color.
This ensures proper appearance in both light and dark modes on iOS.
Moves Instagram web view logic to accommodate handling of dark mode settings.
This change includes removing the InstagramNavigationDelegate and inlining its logic, adds cookie support for setting dark mode preference.
It also adds a new initializer to accept ColorScheme? and determine dark mode.
@cassio-rossi cassio-rossi self-requested a review December 15, 2025 22:07
@cassio-rossi cassio-rossi merged commit aff2ee9 into MacMagazine:release/v5 Dec 15, 2025
2 checks passed
@rfcbf rfcbf deleted the feature/instagram branch December 16, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants