Skip to content

Comments

Exclude source from displayed highlights#350

Merged
jazairi merged 1 commit intomainfrom
use-362
Jan 29, 2026
Merged

Exclude source from displayed highlights#350
jazairi merged 1 commit intomainfrom
use-362

Conversation

@jazairi
Copy link
Contributor

@jazairi jazairi commented Jan 28, 2026

Why these changes are being introduced:

The 'source' field is now redundant with the
search tab names.

Relevant ticket(s):

How this addresses that need:

This adds 'source' to the displayed_fields
method in the Search Helper, thus excluding it
from displayed highlights.

Side effects of this change:

None.

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

Why these changes are being introduced:

The 'source' field is now redundant with the
search tab names.

Relevant ticket(s):

- [USE-362](https://mitlibraries.atlassian.net/browse/USE-362)

How this addresses that need:

This adds 'source' to the `displayed_fields`
method in the Search Helper, thus excluding it
from displayed highlights.

Side effects of this change:

None.
@jazairi jazairi requested a review from JPrevost January 28, 2026 21:19
@coveralls
Copy link

Pull Request Test Coverage Report for Build 21455805586

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.119%

Totals Coverage Status
Change from base Build 21450800061: 0.0%
Covered Lines: 1304
Relevant Lines: 1329

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-362-ma9sghjwb January 28, 2026 21:21 Inactive
@jazairi jazairi merged commit e78f750 into main Jan 29, 2026
5 checks passed
@jazairi jazairi deleted the use-362 branch January 29, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants