Skip to content

docs(hardwareselector.getpixelinformation): use vtkDebugMacro instead…#3399

Merged
finetjul merged 1 commit intoKitware:masterfrom
GMrrc:use-vtkDebugMacro-HardwareSelector
Feb 25, 2026
Merged

docs(hardwareselector.getpixelinformation): use vtkDebugMacro instead…#3399
finetjul merged 1 commit intoKitware:masterfrom
GMrrc:use-vtkDebugMacro-HardwareSelector

Conversation

@GMrrc
Copy link

@GMrrc GMrrc commented Feb 3, 2026

… of console.log

fix #3398

Context

Currently, getPixelInformation always logs debug information to the console.
This can be noisy in production and makes debugging other parts harder.
This PR replaces console.log statements with vtkDebugMacro.
Related feature request: fix #3398

Results

  • Replaced console.log with vtkDebugMacro.
  • No functional changes; existing behavior is preserved by default.
  • Reduces console noise while allowing detailed debugging when needed.

Changes

  • Updated internal logging to use vtkDebugMacro instead of console.log.
  • No breaking changes introduced.
  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js: 34.16.3
    • OS: Windows 11
    • Browser: Chrome 144.0.0.0 (Windows 10)

Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@finetjul
Copy link
Member

finetjul commented Feb 3, 2026

Please rephrase your commit title from "feat" to "docs".
Please rephrase your commit description from "feat #3398" to "fix #3398"

@GMrrc GMrrc force-pushed the use-vtkDebugMacro-HardwareSelector branch from 5c141f6 to 90949b2 Compare February 4, 2026 09:01
@GMrrc GMrrc changed the title feat(hardwareselector.getpixelinformation): use vtkDebugMacro instead… docs(hardwareselector.getpixelinformation): use vtkDebugMacro instead… Feb 4, 2026
Copy link
Collaborator

@sankhesh sankhesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@finetjul finetjul added this pull request to the merge queue Feb 25, 2026
Merged via the queue into Kitware:master with commit cda7c0e Feb 25, 2026
2 checks passed
@github-actions
Copy link

🎉 This PR is included in version 34.16.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Automated label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add a new verbose option to HardwareSelector.getPixelInformation to enable or disable console logging

3 participants