Skip to content

feat(RibbonFilter): add vtkRibbonFilter#3338

Merged
finetjul merged 1 commit intoKitware:masterfrom
daker:feat-ribbonfilter
Feb 26, 2026
Merged

feat(RibbonFilter): add vtkRibbonFilter#3338
finetjul merged 1 commit intoKitware:masterfrom
daker:feat-ribbonfilter

Conversation

@daker
Copy link
Collaborator

@daker daker commented Oct 7, 2025

Context

Results

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a screenshot for the examples gallery

@daker daker force-pushed the feat-ribbonfilter branch from 5de12d5 to 65a78fb Compare October 8, 2025 15:04
@daker daker requested a review from finetjul October 8, 2025 15:15
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@finetjul
Copy link
Member

Apologies for not merging this earlier, can you please rebase ?

@daker
Copy link
Collaborator Author

daker commented Feb 26, 2026

@finetjul is it ok if add a Modeling folder like in CPP or i just use the General folder ?

@finetjul
Copy link
Member

@finetjul is it ok if add a Modeling folder like in CPP or i just use the General folder ?

Yes, good idea.

@daker daker force-pushed the feat-ribbonfilter branch from 65a78fb to 2eee361 Compare February 26, 2026 11:08
@finetjul finetjul added this pull request to the merge queue Feb 26, 2026
Merged via the queue into Kitware:master with commit b05f37b Feb 26, 2026
2 checks passed
@daker daker deleted the feat-ribbonfilter branch February 26, 2026 13:03
@github-actions
Copy link

🎉 This PR is included in version 34.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Automated label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants