kiloclaw: remove IPv4 anycast address provisioning for Fly apps#482
Open
kiloconnect[bot] wants to merge 2 commits intomainfrom
Open
kiloclaw: remove IPv4 anycast address provisioning for Fly apps#482kiloconnect[bot] wants to merge 2 commits intomainfrom
kiloconnect[bot] wants to merge 2 commits intomainfrom
Conversation
Only IPv6 is needed — shared IPv4 allocation was unnecessary overhead. Changes: - Remove shared_v4 IP allocation step from KiloClawApp DO ensureApp() - Remove ipv4Allocated state tracking from DO (kept in schema for backward compat with existing DO storage) - Rename allocateIP() to allocateIPv6() in fly/apps.ts (no longer generic since only v6 is used) - Update isSetupComplete() to only check ipv6Allocated + envKeySet - Remove IPv4-specific test cases, update remaining tests - Update AGENTS.md docs
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Clean refactoring that removes shared IPv4 allocation from the Fly App lifecycle, keeping only IPv6. The changes are consistent across the implementation ( Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (4 files)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the shared IPv4 (anycast) address provisioning from the KiloClaw Cloudflare worker. Only IPv6 is needed for Fly app connectivity — the shared IPv4 allocation was unnecessary overhead.
What changed
kiloclaw/src/durable-objects/kiloclaw-app.tsipv4Allocatedclass property and its tracking inloadState()/destroyApp()ensureApp()isSetupComplete()to only checkipv6Allocated && envKeySet!ipv4Allocated || !ipv6Allocatedto!ipv6Allocatedipv4Allocatedin the Zod schema for backward compatibility with existing DO storage (old DOs may still have this key persisted; it's parsed but ignored)kiloclaw/src/fly/apps.tsallocateIP()→allocateIPv6()since it's no longer generic (only v6 is used)ipTypeparameter andshared_v4type uniontype: 'v6'in the request bodykiloclaw/src/durable-objects/kiloclaw-app.test.tsallocateIP→allocateIPv6kiloclaw/src/fly/apps.test.tsallocateIP→allocateIPv6kiloclaw/AGENTS.mdVerification
allocateIPorshared_v4Built for Florian by Kilo for Slack