Closed
Conversation
Member
Author
|
Wait a minute, it's not clear for you to review the PR since the base commit was a super old commit. I will close and open a cleaner one. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
==========================================
- Coverage 98.55% 98.53% -0.02%
==========================================
Files 28 29 +1
Lines 4967 4968 +1
==========================================
Hits 4895 4895
- Misses 72 73 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @baggepinnen,
Do you have experience with package extension? I tried to add a simple package extension
LinearMPCextin this PR, and no matter what, I'm not able to call the dummyhifunction. Do you spot an obvious problem? I used ChatGPT and Claude to revise the file structure and myProject.tomland they were not helpful at all.The goal here would be to load the code generation tools only if
LinearMPCis available and loaded.Many thanks!