Fix issue : alert gains and tot tables not found#1149
Draft
ftouchte wants to merge 3 commits intoJeffersonLab:developmentfrom
Draft
Fix issue : alert gains and tot tables not found#1149ftouchte wants to merge 3 commits intoJeffersonLab:developmentfrom
ftouchte wants to merge 3 commits intoJeffersonLab:developmentfrom
Conversation
…rt/ahdc/time_over_threshold not found
Collaborator
|
Are they still being read from the database in AHDC's engine? If so, can that be disabled? |
Collaborator
Author
|
We still need the CCDB in the AHDCEngine. That why the AHDCTest failed. But if we run the ATOFEngine just before the AHDCEngine, we don't need to load it again. (I will just revoke my last commit.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this error for a very long time, but it is only now that I notice that (may be) the calibration constants for the gain and the ToT were never taken into account.
Before this PR
After this PR
This way of handling the code masked the issue :
coatjava/reconstruction/alert/src/main/java/org/jlab/rec/ahdc/Hit/HitReader.java
Lines 158 to 165 in 1ccf10a
Fortunately, the ADC calibration has no effect on the Kalman Filter.
In any case, the error disappears with the pull request.