Conversation
pUrl previously called 'fromMaybe (error "Url longer than 64 bytes")', which crashes the process when the user supplies a URL longer than 64 bytes. Restructure to use Opt.option with a custom ReadM that calls Opt.readerError, so an invalid URL produces a clean optparse-applicative parse failure with a useful message.
hprop_lovelace_reader: round-trips arbitrary Word64 values through parseLovelace, and asserts that negative values and overflow (> Word64 max) are rejected. hprop_url_reader: confirms that pUrl accepts URLs of 64 bytes or fewer and returns Nothing (clean parse failure, not a crash) for URLs longer than 64 bytes, exercising the readerError path added in the previous commit. Also adds optparse-applicative-fork to the cardano-cli-test build-depends so the parser test can run execParserPure.
Jimbo4350
requested review from
carbolymer,
disassembler,
kevinhammond,
newhoggy and
palas
as code owners
carbolymer
reviewed
Feb 24, 2026
| urlStr <- readerAsk | ||
| let urlText = Text.pack urlStr | ||
| maybe (Opt.readerError $ "URL must be 64 bytes or fewer, got: " <> urlStr) pure $ | ||
| L.textToUrl 128 urlText |
Contributor
There was a problem hiding this comment.
the message says 64, but you're checking for maximum length 128
carbolymer
reviewed
Feb 24, 2026
| import qualified Hedgehog.Range as Gen | ||
| import qualified Hedgehog.Range as Range | ||
| import Options.Applicative (defaultPrefs, execParserPure, getParseResult, info) | ||
| import qualified Text.Parsec as Parsec |
Contributor
There was a problem hiding this comment.
Use Cardano.Api.Parser.Text instead. There are few convenience functions, which could be useful for you.
carbolymer
requested changes
Feb 24, 2026
Contributor
carbolymer
left a comment
carbolymer
left a comment
There was a problem hiding this comment.
This branches off in October. Needs rebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist