Move build system to meson-python#166
Draft
ndgrigorian wants to merge 7 commits intoadd-pre-commitfrom
Draft
Conversation
ndgrigorian
force-pushed
the
build-with-meson
branch
2 times, most recently
from
1434bc2 to
5e8ef5a
Compare
ndgrigorian
force-pushed
the
add-pre-commit
branch
from
52b0dcf to
e73dc73
Compare
* removes cmake and setup.py from the project * vendors process_src_template.py from numpy and updates vendored conv_template.py * updates build scripts * updates meta.yaml * updates pyproject.toml * adds meson.build and meson.options
also fix license in pyproject.toml
ndgrigorian
force-pushed
the
build-with-meson
branch
5 times, most recently
from
7282603 to
871aafd
Compare
add workflow using standard clang
ndgrigorian
force-pushed
the
build-with-meson
branch
from
871aafd to
ca5feea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes moving from scikit-build to meson-python as the mkl_umath build system
meson-python is already used by NumPy and eliminates the need for CMake, while also allowing setup.py to be removed (with its logic moved into the meson.build script)
Following the approach in NumPy,
vendored/process_src_template.pyis vendored from NumPy to be called from the build script, automating the processing ofconv_template.py