Add scipy.linalg.lu() decomposition support#2787
Open
abagusetty wants to merge 24 commits intoIntelPython:masterfrom
Open
Add scipy.linalg.lu() decomposition support#2787abagusetty wants to merge 24 commits intoIntelPython:masterfrom
scipy.linalg.lu() decomposition support#2787abagusetty wants to merge 24 commits intoIntelPython:masterfrom
Conversation
abagusetty
requested review from
antonwolfy,
ndgrigorian and
vlad-perevezentsev
as code owners
|
Can one of the admins verify this patch? |
antonwolfy
reviewed
Mar 2, 2026
Contributor
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
@abagusetty, thank you for the contribution. I posted few comments below
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
Author
|
@antonwolfy Thanks for taking time. All the suggestions were addressed. Please let me know |
Collaborator
antonwolfy
reviewed
Mar 3, 2026
Comment on lines
+2976
to
+2983
| A_cast = a_dp.astype( | ||
| ( | ||
| dpnp.complex128 | ||
| if dpnp.issubdtype(dtype, dpnp.complexfloating) | ||
| else dpnp.float64 | ||
| ), | ||
| copy=False, | ||
| ) |
Contributor
There was a problem hiding this comment.
A_cast seems never used
Suggested change
| A_cast = a_dp.astype( | |
| ( | |
| dpnp.complex128 | |
| if dpnp.issubdtype(dtype, dpnp.complexfloating) | |
| else dpnp.float64 | |
| ), | |
| copy=False, | |
| ) |
| U_np = dpnp.asnumpy(U) | ||
| A_rec = L_np[p_np] @ U_np | ||
| A_cast = a_dp.astype(L.dtype, copy=False) | ||
| assert_allclose(A_rec, dpnp.asnumpy(A_cast), rtol=1e-6, atol=1e-6) |
Contributor
There was a problem hiding this comment.
Why do we need to cast to numpy array? Can we use the assert like in above tests?
Suggested change
| assert_allclose(A_rec, dpnp.asnumpy(A_cast), rtol=1e-6, atol=1e-6) | |
| assert dpnp.allclose(A_rec, A_cast, rtol=1e-6, atol=1e-6) |
| if m == 1 and n == 1: | ||
| if check_finite: | ||
| if not dpnp.isfinite(a).all(): | ||
| raise ValueError("array must not contain infs or NaNs") |
Contributor
There was a problem hiding this comment.
It seems there is no test covering that. Could you please add it?
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
dpnp.scipy.linalg.lu()with support for all three output modes: default(P, L, U),permute_l=True (PL, U), andp_indices=True(p, L, U), including batched inputs.Fixes: #2786