Resolve deprecation warnings when building Cython examples#1935
Resolve deprecation warnings when building Cython examples#1935oleksandr-pavlyk merged 9 commits intomasterfrom
Conversation
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_325 ran successfully. |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_326 ran successfully. |
|
The warnings in The folder |
|
The immediate reason is that Compiler finds these header files instead of those packages in the compiler itself in |
…to align with the expected name of native extension
42a6f0b to
7c903b6
Compare
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_345 ran successfully. |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_346 ran successfully. |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_340 ran successfully. |
|
I've changed build system for Cython examples over to scikit-build, and the warnings are now all gone. |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_341 ran successfully. |
ndgrigorian
left a comment
There was a problem hiding this comment.
Warnings are gone so this LGTM!
This PR adds
conda listof the build environment to help understand the origin of compiler warnings in CI which are not reproducible locally.Edit:
This PR resolves the issue by upgrading building system for Cython examples to use scikit-build.
CMake ensures that header files from the correct location are used.