fix(IgxGrid): Do not apply width constraint to groups.#17071
Open
MayaKirova wants to merge 2 commits into20.1.xfrom
Open
fix(IgxGrid): Do not apply width constraint to groups.#17071MayaKirova wants to merge 2 commits into20.1.xfrom
MayaKirova wants to merge 2 commits into20.1.xfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an IgxGrid layout issue where collapsed column groups were incorrectly constrained by the default minimum column width, leading to header/cell misalignment when explicit child widths are used.
Changes:
- Adjust column size computation so default min-width constraint is not applied to column groups.
- Add a new grid test sample component representing a collapsible group with explicit child widths.
- Add a regression test ensuring a collapsed group’s calculated width matches the visible child column width.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/igniteui-angular/src/lib/test-utils/grid-samples.spec.ts | Adds a standalone test component with a collapsed group whose visible child has an explicit width. |
| projects/igniteui-angular/src/lib/grids/grid/grid-collapsible-columns.spec.ts | Adds a regression test for #17042 verifying group width isn’t forced to the default min width. |
| projects/igniteui-angular/src/lib/grids/columns/column.component.ts | Updates constrained-width logic to avoid applying default min width to column groups and uses the correct constraint target when filling child column sizes. |
Comment on lines
+622
to
+623
| it('should not constrain collapsed column group width by default min width when children have explicit widths (#17042)', () => { | ||
| const fix = TestBed.createComponent(CollapsibleGroupWithExplicitChildWidthsComponent); |
There was a problem hiding this comment.
The test is declared with fit(...), which will focus this spec and cause the rest of the suite to be skipped in CI/local runs. Replace fit with it (or remove focus) so the full test suite executes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17042
No need to apply default width constraint (136px) to groups, as individual child column already apply it.
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)