Skip to content

fix(IgxGrid): Do not apply width constraint to groups. #17070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MayaKirova wants to merge 3 commits into
base: 21.1.x
Choose a base branch
from
+55 −7
Open

fix(IgxGrid): Do not apply width constraint to groups. #17070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10ae380
fix(IgxGrid): Do not apply width constraint to groups.
MayaKirova Mar 20, 2026
ceb8a81
chore(*): Remove leftover fit.
MayaKirova Mar 20, 2026
6e82d1f
Merge branch '21.1.x' into mkirova/fix-17042-21.1.x
ChronosSF Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions projects/igniteui-angular/grids/core/src/columns/column.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2189,7 +2189,8 @@ export class IgxColumnComponent implements AfterContentInit, OnDestroy, ColumnTy
result.push(size.width + 'px');
} else {
const currentWidth = parseFloat(this.grid.getPossibleColumnWidth());
result.push((this.getConstrainedSizePx(currentWidth)) + 'px');
const target = size && size.ref ? size.ref : this;
result.push((target as IgxColumnComponent).getConstrainedSizePx(currentWidth) + 'px');
}
}
return result;
Expand Down Expand Up @@ -2682,7 +2683,7 @@ export class IgxColumnComponent implements AfterContentInit, OnDestroy, ColumnTy
} else if (this.minWidth && newSize <= this.userSetMinWidthPx) {
this.widthConstrained = true;
return this.userSetMinWidthPx;
} else if (!this.minWidth && (!this.widthSetByUser || this.width === 'fit-content') && !this.grid.columnWidthSetByUser && (!newSize || newSize <= this.grid.minColumnWidth)) {
} else if (!this.columnGroup && !this.minWidth && (!this.widthSetByUser || this.width === 'fit-content') && !this.grid.columnWidthSetByUser && (!newSize || newSize <= this.grid.minColumnWidth)) {
return this.grid.minColumnWidth;
} else {
this.widthConstrained = false;
Expand Down
28 changes: 26 additions & 2 deletions projects/igniteui-angular/grids/grid/src/grid-collapsible-columns.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import {
CollapsibleColumnGroupTestComponent,
CollapsibleGroupsTemplatesTestComponent,
CollapsibleGroupsDynamicColComponent
CollapsibleGroupsDynamicColComponent,
CollapsibleGroupWithExplicitChildWidthsComponent
} from '../../../test-utils/grid-samples.spec';
import { GridFunctions } from '../../../test-utils/grid-functions.spec';
import { UIInteractions, wait } from '../../../test-utils/ui-interactions.spec';
Expand All @@ -28,7 +29,8 @@ describe('IgxGrid - multi-column headers #grid', () => {
NoopAnimationsModule,
CollapsibleColumnGroupTestComponent,
CollapsibleGroupsTemplatesTestComponent,
CollapsibleGroupsDynamicColComponent
CollapsibleGroupsDynamicColComponent,
CollapsibleGroupWithExplicitChildWidthsComponent
]
}).compileComponents();
}));
Expand Down Expand Up @@ -617,6 +619,28 @@ describe('IgxGrid - multi-column headers #grid', () => {
expect(spans.length).toBe(2);
});

it('should not constrain collapsed column group width by default min width when children have explicit widths (#17042)', () => {
const fix = TestBed.createComponent(CollapsibleGroupWithExplicitChildWidthsComponent);
fix.detectChanges();
const g: IgxGridComponent = fix.componentInstance.grid;

const customerInfoGroup = GridFunctions.getColGroup(g, 'Customer Information');
expect(customerInfoGroup.expanded).toBe(false);
expect(customerInfoGroup.collapsible).toBe(true);

// The only visible child when collapsed is CompanyName with width 100px.
const visibleChildren = customerInfoGroup.children
.filter(c => !c.hidden);
expect(visibleChildren.length).toBe(1);

const visibleChildWidth = visibleChildren
.reduce((sum, c) => sum + c.calcPixelWidth, 0);

const groupWidth = customerInfoGroup.calcPixelWidth;
expect(groupWidth).toBe(visibleChildWidth);
expect(groupWidth).toBe(100);
});

it('Group By: test when group by a column', () => {
addressInf.expanded = false;
countryCol.visibleWhenCollapsed = false;
Expand Down
23 changes: 23 additions & 0 deletions projects/igniteui-angular/test-utils/grid-samples.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2794,3 +2794,26 @@ export class IgxGridRowEditingDefinedColumnsComponent extends BasicGridComponent
})
export class IgxGridConditionalFilteringComponent extends IgxGridFilteringComponent {
}

@Component({
template: `
<igx-grid #grid [data]="data" height="500px" width="600px">
<igx-column-group header="Customer Information" [collapsible]="true" [expanded]="false">
<igx-column field="CompanyName" width="100px" [visibleWhenCollapsed]="true"></igx-column>
<igx-column field="ContactName" width="100px" [visibleWhenCollapsed]="false"></igx-column>
<igx-column field="ContactTitle" width="100px" [visibleWhenCollapsed]="false"></igx-column>
</igx-column-group>
<igx-column field="ID" width="200px"></igx-column>
<igx-column field="Address" width="200px"></igx-column>
<igx-column field="City" width="200px"></igx-column>
<igx-column field="Country" width="200px"></igx-column>
<igx-column field="Phone" width="200px"></igx-column>
</igx-grid>
`,
imports: [IgxGridComponent, IgxColumnComponent, IgxColumnGroupComponent]
})
export class CollapsibleGroupWithExplicitChildWidthsComponent {
@ViewChild(IgxGridComponent, { read: IgxGridComponent, static: true })
public grid: IgxGridComponent;
public data = SampleTestData.contactInfoDataFull();
}
6 changes: 3 additions & 3 deletions src/app/grid-column-groups/grid-column-groups.sample.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,8 @@
<igx-column [filterable]="true" [sortable]="true" [resizable]="true" field="Region" [visibleWhenCollapsed]="false"></igx-column>
<igx-column [filterable]="true" [sortable]="true" [resizable]="true" field="City" [visibleWhenCollapsed]="false"></igx-column>
<igx-column [filterable]="true" [sortable]="true" [resizable]="true" field="Address" [visibleWhenCollapsed]="false"></igx-column>
<igx-column [filterable]="true" [editable]="true" [sortable]="true" [visibleWhenCollapsed]="true" field="FullAddress"></igx-column>
<igx-column [filterable]="true" [editable]="true" [sortable]="true" [visibleWhenCollapsed]="true" width="100px" field="FullAddress"></igx-column>
</igx-column-group>
<!-- <igx-column field="Missing"></igx-column>
<igx-column field="Missing"></igx-column>
<igx-column field="Missing"></igx-column>
<igx-column field="Missing"></igx-column>
Expand All @@ -45,7 +44,8 @@
<igx-column field="Missing"></igx-column>
<igx-column field="Missing"></igx-column>
<igx-column field="Missing"></igx-column>
<igx-column field="Missing"></igx-column> -->
<igx-column field="Missing"></igx-column>
<igx-column field="Missing"></igx-column>
<igx-column-group header="Address Information">
<igx-column-group header="Location">
<igx-column [filterable]="true" [sortable]="true" [resizable]="true" field="Country"></igx-column>
Expand Down
Loading