fix(IgxGrid): Do not apply width constraint to groups.#17069
Open
MayaKirova wants to merge 2 commits intomasterfrom
Open
fix(IgxGrid): Do not apply width constraint to groups.#17069MayaKirova wants to merge 2 commits intomasterfrom
MayaKirova wants to merge 2 commits intomasterfrom
Conversation
MayaKirova
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a regression in IgxGrid where collapsed column groups could be incorrectly constrained to the grid’s default minimum column width (e.g. 136px), leading to header/cell misalignment when child columns have explicit widths.
Changes:
- Adjust column sizing logic to avoid applying the default min-width constraint to column groups and to constrain “gap-filled” sizes using the referenced child column.
- Add a targeted unit test reproducing the “collapsed group + explicit child widths” scenario from #17042.
- Update the demo/sample markup to include an explicit width on a
visibleWhenCollapsedchild column (to better match the reported scenario).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
projects/igniteui-angular/grids/core/src/columns/column.component.ts |
Prevents default min-width constraint from being applied to column groups; constrains computed sizes using the appropriate column reference. |
projects/igniteui-angular/grids/grid/src/grid-collapsible-columns.spec.ts |
Adds a regression test asserting collapsed group width matches the sum of visible child widths. |
projects/igniteui-angular/test-utils/grid-samples.spec.ts |
Introduces a new standalone test component used by the new regression test. |
src/app/grid-column-groups/grid-column-groups.sample.html |
Tweaks the sample to set an explicit width on a collapsed-visible column. |
| expect(spans.length).toBe(2); | ||
| }); | ||
|
|
||
| fit('should not constrain collapsed column group width by default min width when children have explicit widths (#17042)', () => { |
There was a problem hiding this comment.
Focused spec fit(...) is committed; this will cause the test runner to execute only this spec and skip the rest of the suite in CI. Replace fit with a regular it (or remove focus) so the full suite runs.
Suggested change
| fit('should not constrain collapsed column group width by default min width when children have explicit widths (#17042)', () => { | |
| it('should not constrain collapsed column group width by default min width when children have explicit widths (#17042)', () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17042
No need to apply default width constraint (136px) to groups, as individual child column already apply it.
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)