Skip to content

fix(*): add tile manager to skills - 21.1.x#17058

Merged
kdinev merged 3 commits into21.1.xfrom
mtsvyatkova/tile-manager-skill-21.1.x
Mar 23, 2026
Merged

fix(*): add tile manager to skills - 21.1.x#17058
kdinev merged 3 commits into21.1.xfrom
mtsvyatkova/tile-manager-skill-21.1.x

Conversation

@mtsvyatkova
Copy link
Contributor

@mtsvyatkova mtsvyatkova commented Mar 17, 2026

Closes #17046

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@mtsvyatkova mtsvyatkova added ❌ status: awaiting-test PRs awaiting manual verification version: 21.1.x labels Mar 17, 2026
@mtsvyatkova mtsvyatkova requested a review from ChronosSF March 18, 2026 07:13
@kdinev kdinev requested a review from Copilot March 20, 2026 09:39
kdinev
kdinev previously approved these changes Mar 20, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the igniteui-angular-components skill documentation to include Tile Manager alongside existing Layout Manager and Dock Manager guidance, addressing the missing coverage reported in #17046.

Changes:

  • Expand the Layout/Dock Manager reference to include a new Tile Manager section and TOC entry.
  • Update the skill hub metadata/description to mention Tile Manager.
  • Update the Task → Reference File routing table to include Tile Manager in the layout-manager reference row.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
skills/igniteui-angular-components/references/layout-manager.md Renames the page header, adds TOC entry, and adds a full Tile Manager documentation section.
skills/igniteui-angular-components/SKILL.md Updates skill description and routing table row to include Tile Manager.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment on lines +432 to +437
Register the Tile Manager Web Component before bootstrap:

```typescript
import { defineComponents, IgcTileManagerComponent } from 'igniteui-webcomponents';

defineComponents(IgcTileManagerComponent);
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Tile Manager setup snippet says to register the web component “before bootstrap”, but (unlike the Dock Manager section above) it doesn’t specify the concrete placement (e.g., main.ts before bootstrapApplication). Adding that call-site guidance would prevent users from registering too late and getting “unknown element” behavior.

Suggested change
Register the Tile Manager Web Component before bootstrap:
```typescript
import { defineComponents, IgcTileManagerComponent } from 'igniteui-webcomponents';
defineComponents(IgcTileManagerComponent);
In your `main.ts`, register the Tile Manager Web Component **before** calling `bootstrapApplication`:
```typescript
import { bootstrapApplication } from '@angular/platform-browser';
import { AppComponent } from './app/app.component';
import { defineComponents, IgcTileManagerComponent } from 'igniteui-webcomponents';
defineComponents(IgcTileManagerComponent);
bootstrapApplication(AppComponent);

Copilot uses AI. Check for mistakes.
Comment on lines +443 to +447
import { Component, CUSTOM_ELEMENTS_SCHEMA } from '@angular/core';

@Component({
selector: 'app-tile-manager',
templateUrl: './tile-manager.component.html',
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Tile Manager component example omits changeDetection: ChangeDetectionStrategy.OnPush, while the rest of the skill references generally default to OnPush in component examples. Consider adding OnPush here as well (and the corresponding ChangeDetectionStrategy import) so the snippet reflects the recommended Angular performance setup.

Suggested change
import { Component, CUSTOM_ELEMENTS_SCHEMA } from '@angular/core';
@Component({
selector: 'app-tile-manager',
templateUrl: './tile-manager.component.html',
import { ChangeDetectionStrategy, Component, CUSTOM_ELEMENTS_SCHEMA } from '@angular/core';
@Component({
selector: 'app-tile-manager',
templateUrl: './tile-manager.component.html',
changeDetection: ChangeDetectionStrategy.OnPush,

Copilot uses AI. Check for mistakes.
@kdinev kdinev merged commit cd5e668 into 21.1.x Mar 23, 2026
9 checks passed
@kdinev kdinev deleted the mtsvyatkova/tile-manager-skill-21.1.x branch March 23, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version: 21.1.x ❌ status: awaiting-test PRs awaiting manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants