fix(skills): add igx-buttongroup and icon button to igniteui-angular-components skill#17003
fix(skills): add igx-buttongroup and icon button to igniteui-angular-components skill#17003
Conversation
… skill Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the igniteui-angular-components skill documentation to explicitly cover igx-buttongroup / IgxButtonGroupComponent, so agents can rely on in-repo references instead of external discovery.
Changes:
- Added a new “Button Group” section to
references/directives.mdincluding import paths, selection/alignment/disabled examples, event handling, and basic programmatic control guidance. - Extended
references/setup.mdwith theigniteui-angular/button-groupentry point and theIGX_BUTTON_GROUP_DIRECTIVESconvenience collection. - Updated the skill hub (
SKILL.md) routing/description so “Button Group” is discoverable via the directives reference.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| skills/igniteui-angular-components/references/setup.md | Documents the Button Group entry point and convenience directives collection token. |
| skills/igniteui-angular-components/references/directives.md | Adds Button Group API guidance, examples, and event args overview to the directives reference. |
| skills/igniteui-angular-components/SKILL.md | Updates the skill’s routing/description to include Button Group under directives. |
| | `(selected)` | `IButtonGroupEventArgs` | A button is selected. | | ||
| | `(deselected)` | `IButtonGroupEventArgs` | A button is deselected. | | ||
|
|
||
| `IButtonGroupEventArgs`: `{ owner: IgxButtonGroupComponent; button: IgxButtonDirective; index: number }`. |
There was a problem hiding this comment.
IButtonGroupEventArgs is described as including button: IgxButtonDirective, but this section never states where IgxButtonDirective should be imported from (and the earlier import block doesn’t include it). Adding the import path for IgxButtonDirective (or linking it back to the Button directive section) would make the event-args shape actionable and avoid ambiguity.
| `IButtonGroupEventArgs`: `{ owner: IgxButtonGroupComponent; button: IgxButtonDirective; index: number }`. | |
| `IButtonGroupEventArgs`: `{ owner: IgxButtonGroupComponent; button: IgxButtonDirective; index: number }`, where `IgxButtonDirective` is imported from `igniteui-angular/directives` (see **Button & Icon Button** section above). |
| ```typescript | ||
| import { IgxButtonGroupComponent, IGX_BUTTON_GROUP_DIRECTIVES } from 'igniteui-angular/button-group'; | ||
| import { IgxIconComponent } from 'igniteui-angular/icon'; | ||
| ``` | ||
|
|
||
| Use `IGX_BUTTON_GROUP_DIRECTIVES` (includes `IgxButtonGroupComponent` + `IgxButtonDirective`) for convenience, or import individually. | ||
|
|
There was a problem hiding this comment.
The import example brings in both IgxButtonGroupComponent and IGX_BUTTON_GROUP_DIRECTIVES, but the text below says to use the directive collection or import individually. Consider splitting this into two alternative import examples (collection vs. individual) or removing the redundant symbol to avoid confusing readers about what they actually need to import.
|
@copilot address the merge conflict, ensure "user-invocable" is used and both "Icon Button, Button Group" are added as part of the incomming change description. |
…ton + Button Group to description Co-authored-by: zdrawku <11193764+zdrawku@users.noreply.github.com>
Done in 0cf6fbd. All three issues addressed:
Also addressed the PR review feedback: split the import block into Option A (convenience collection) and Option B (individual imports), and added the |
…into copilot/fix-igx-buttongroup-skill
…components skill (#17003) * Initial plan * fix: add igx-buttongroup documentation to igniteui-angular-components skill Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com> * fix(skills): resolve merge conflict, use user-invocable, add Icon Button + Button Group to description Co-authored-by: zdrawku <11193764+zdrawku@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com> Co-authored-by: zdrawku <11193764+zdrawku@users.noreply.github.com> Co-authored-by: zdrawku <zkolev@infragistics.com>
IgxButtonGroupComponentwas completely absent from the components skill, causing agents to fall back to shell commands to discover the API rather than using documented references. Additionally, the skill front-matter and description did not explicitly mention Icon Button or Button Group, and used the incorrectuser-invokablekey instead ofuser-invocable.Changes
references/directives.md— New "Button Group" section with:IGX_BUTTON_GROUP_DIRECTIVES) and Option B (individualIgxButtonGroupComponent+IgxButtonDirective)IButtonGroupEventArgsshape (withIgxButtonDirectiveimport path clarified)viewChild## Contentstable listing all sections (matching base branch format)references/setup.md— AddedButton Group → igniteui-angular/button-groupto the entry points table; addedIGX_BUTTON_GROUP_DIRECTIVESto the convenience collections tableSKILL.md:user-invokable→user-invocablein front-matterdescriptionto use the improved base branch format, explicitly includingicon buttonandbutton groupin the directives sectionIcon Button, Button GroupExample usage an agent can now produce correctly
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.