Skip to content

fix(skills): add igx-buttongroup and icon button to igniteui-angular-components skill#17003

Merged
zdrawku merged 4 commits into21.1.xfrom
copilot/fix-igx-buttongroup-skill
Mar 9, 2026
Merged

fix(skills): add igx-buttongroup and icon button to igniteui-angular-components skill#17003
zdrawku merged 4 commits into21.1.xfrom
copilot/fix-igx-buttongroup-skill

Conversation

Copy link
Contributor

Copilot AI commented Mar 6, 2026

IgxButtonGroupComponent was completely absent from the components skill, causing agents to fall back to shell commands to discover the API rather than using documented references. Additionally, the skill front-matter and description did not explicitly mention Icon Button or Button Group, and used the incorrect user-invokable key instead of user-invocable.

Changes

  • references/directives.md — New "Button Group" section with:

    • Split import examples: Option A (convenience collection IGX_BUTTON_GROUP_DIRECTIVES) and Option B (individual IgxButtonGroupComponent + IgxButtonDirective)
    • Examples for all three selection modes, alignment, disabled state, and event handling
    • Input/output API tables and IButtonGroupEventArgs shape (with IgxButtonDirective import path clarified)
    • Programmatic control via signal-based viewChild
    • Added ## Contents table listing all sections (matching base branch format)
  • references/setup.md — Added Button Group → igniteui-angular/button-group to the entry points table; added IGX_BUTTON_GROUP_DIRECTIVES to the convenience collections table

  • SKILL.md:

    • Fixed user-invokableuser-invocable in front-matter
    • Updated description to use the improved base branch format, explicitly including icon button and button group in the directives section
    • Updated routing table row to include Icon Button, Button Group
    • Updated Step 2 to use the parallel reads protocol from the base branch

Example usage an agent can now produce correctly

import { IGX_BUTTON_GROUP_DIRECTIVES } from 'igniteui-angular/button-group';

@Component({
  imports: [IGX_BUTTON_GROUP_DIRECTIVES],
  template: `
    <igx-buttongroup selectionMode="singleRequired" (selected)="onSelected($event)">
      <button igxButton [selected]="true">Day</button>
      <button igxButton>Week</button>
      <button igxButton>Month</button>
    </igx-buttongroup>
  `
})
export class CalendarViewComponent { ... }
Original prompt

This section details on the original issue you should resolve

<issue_title>igx-buttongroup not found in skills</issue_title>
<issue_description>## Description
I have an application, which can use a button group component, but the components skill doesn't tell the agent such a component exists

  • igniteui-angular version: 21.1.0
  • browser: n/a

Steps to reproduce

  1. Make a project and add igniteui-angular skills to it
  2. Ask an agent to implement piece of the UI with the igx-buttongroup component.

Result

The skill doesn't tell the agent there's such a component.

Expected result

Button group is correctly implemented by the agent, without having to go out and search documentation.

Attachments

Image

</issue_description>

Comments on the Issue (you are @copilot in this section)


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

… skill

Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix igx-buttongroup component not found in skills fix(skills): add igx-buttongroup to igniteui-angular-components skill Mar 6, 2026
@kdinev kdinev marked this pull request as ready for review March 9, 2026 10:02
@kdinev kdinev requested review from Copilot and damyanpetev March 9, 2026 10:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the igniteui-angular-components skill documentation to explicitly cover igx-buttongroup / IgxButtonGroupComponent, so agents can rely on in-repo references instead of external discovery.

Changes:

  • Added a new “Button Group” section to references/directives.md including import paths, selection/alignment/disabled examples, event handling, and basic programmatic control guidance.
  • Extended references/setup.md with the igniteui-angular/button-group entry point and the IGX_BUTTON_GROUP_DIRECTIVES convenience collection.
  • Updated the skill hub (SKILL.md) routing/description so “Button Group” is discoverable via the directives reference.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
skills/igniteui-angular-components/references/setup.md Documents the Button Group entry point and convenience directives collection token.
skills/igniteui-angular-components/references/directives.md Adds Button Group API guidance, examples, and event args overview to the directives reference.
skills/igniteui-angular-components/SKILL.md Updates the skill’s routing/description to include Button Group under directives.

| `(selected)` | `IButtonGroupEventArgs` | A button is selected. |
| `(deselected)` | `IButtonGroupEventArgs` | A button is deselected. |

`IButtonGroupEventArgs`: `{ owner: IgxButtonGroupComponent; button: IgxButtonDirective; index: number }`.
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IButtonGroupEventArgs is described as including button: IgxButtonDirective, but this section never states where IgxButtonDirective should be imported from (and the earlier import block doesn’t include it). Adding the import path for IgxButtonDirective (or linking it back to the Button directive section) would make the event-args shape actionable and avoid ambiguity.

Suggested change
`IButtonGroupEventArgs`: `{ owner: IgxButtonGroupComponent; button: IgxButtonDirective; index: number }`.
`IButtonGroupEventArgs`: `{ owner: IgxButtonGroupComponent; button: IgxButtonDirective; index: number }`, where `IgxButtonDirective` is imported from `igniteui-angular/directives` (see **Button & Icon Button** section above).

Copilot uses AI. Check for mistakes.
Comment on lines +40 to +46
```typescript
import { IgxButtonGroupComponent, IGX_BUTTON_GROUP_DIRECTIVES } from 'igniteui-angular/button-group';
import { IgxIconComponent } from 'igniteui-angular/icon';
```

Use `IGX_BUTTON_GROUP_DIRECTIVES` (includes `IgxButtonGroupComponent` + `IgxButtonDirective`) for convenience, or import individually.

Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import example brings in both IgxButtonGroupComponent and IGX_BUTTON_GROUP_DIRECTIVES, but the text below says to use the directive collection or import individually. Consider splitting this into two alternative import examples (collection vs. individual) or removing the redundant symbol to avoid confusing readers about what they actually need to import.

Copilot uses AI. Check for mistakes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

@kdinev kdinev requested a review from zdrawku March 9, 2026 11:36
@zdrawku
Copy link
Contributor

zdrawku commented Mar 9, 2026

@copilot address the merge conflict, ensure "user-invocable" is used and both "Icon Button, Button Group" are added as part of the incomming change description.

…ton + Button Group to description

Co-authored-by: zdrawku <11193764+zdrawku@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 9, 2026

@copilot address the merge conflict, ensure "user-invocable" is used and both "Icon Button, Button Group" are added as part of the incomming change description.

Done in 0cf6fbd. All three issues addressed:

  • Merge conflict: Updated all files to incorporate the base branch changes (improved description format, user-invocable: true, parallel STEP 2 protocol, Contents table in directives.md)
  • user-invocable: Changed from user-invokable to user-invocable in SKILL.md front matter
  • "Icon Button, Button Group": Added both to the skill description (directives (button, icon button, button group, ripple, tooltip, drag-and-drop)) and to the routing table row

Also addressed the PR review feedback: split the import block into Option A (convenience collection) and Option B (individual imports), and added the IgxButtonDirective import path to the IButtonGroupEventArgs description.

Copilot AI changed the title fix(skills): add igx-buttongroup to igniteui-angular-components skill fix(skills): add igx-buttongroup and icon button to igniteui-angular-components skill Mar 9, 2026
@zdrawku zdrawku merged commit 1c8d6ca into 21.1.x Mar 9, 2026
4 checks passed
@zdrawku zdrawku deleted the copilot/fix-igx-buttongroup-skill branch March 9, 2026 14:16
zdrawku added a commit that referenced this pull request Mar 9, 2026
…components skill (#17003)

* Initial plan

* fix: add igx-buttongroup documentation to igniteui-angular-components skill

Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>

* fix(skills): resolve merge conflict, use user-invocable, add Icon Button + Button Group to description

Co-authored-by: zdrawku <11193764+zdrawku@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>
Co-authored-by: zdrawku <11193764+zdrawku@users.noreply.github.com>
Co-authored-by: zdrawku <zkolev@infragistics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants