-
Notifications
You must be signed in to change notification settings - Fork 160
refactor(overlay): stop moving to body container & deprecate outlet #16989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wnvko
wants to merge
5
commits into
master
Choose a base branch
from
mvenkov/do-not-move-overlay-element-from-its-position
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,218
−811
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
66c36b1
feat(overlay): do not move overlay element
wnvko 91d3085
feat(overlay): remove outlet from container position strategy
wnvko 4293ad4
docs(notifications): update snackbar and toast samples
wnvko 3e0818d
Merge branch 'master' into mvenkov/do-not-move-overlay-element-from-i…
wnvko f34760b
Merge branch 'master' into mvenkov/do-not-move-overlay-element-from-i…
damyanpetev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -73,12 +73,12 @@ this.overlay.show(component, overlaySettings); | |||||
|
|
||||||
| | Name | Type | Description | | ||||||
| | :--- | :--- | :---------- | | ||||||
| | target | Point | HTMLElement | Attaching target for the component to show | | ||||||
| | target | Point | HTMLElement | Attaching target for the component to show. When set to an `HTMLElement` in combination with `ContainerPositionStrategy`, the element serves as the container in which the overlay is rendered. | | ||||||
| | positionStrategy | IPositionStrategy | Position strategy to use with this settings | | ||||||
| | scrollStrategy | IScrollStrategy | Scroll strategy to use with this settings | | ||||||
| | modal | boolean | Set if the overlay should be in modal mode | | ||||||
| | closeOnOutsideClick | boolean | Set if the overlay should closed on outside click | | ||||||
| | outlet | IgxOverlayOutletDirective or ElementRef | Set the outlet container to attach the overlay to | | ||||||
| | outlet | IgxOverlayOutletDirective or ElementRef | **Deprecated.** Use `target` with an `HTMLElement` and `ContainerPositionStrategy` instead. Still supported for backward compatibility but will be removed in a future version. | | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| ###### PositionSettings | ||||||
|
|
||||||
|
|
@@ -135,7 +135,7 @@ this.overlay.show(component, overlaySettings); | |||||
| | Name | Description | Parameters | | ||||||
| |-----------------|---------------------------------------------------------------------------------|------------| | ||||||
| |getPointFromPositionsSettings| Calculates the point from which the overlay should start showing |settings | | ||||||
| |createAbsoluteOverlaySettings| Creates overlay settings with global or container position strategy based on a preset position settings |position?, outlet?| | ||||||
| |createAbsoluteOverlaySettings| Creates overlay settings with a global or container position strategy based on preset position settings. Accepts either a deprecated outlet (`IgxOverlayOutletDirective` / `ElementRef`) or an `HTMLElement` container. When a container or outlet is provided, a `ContainerPositionStrategy` is used; otherwise, a `GlobalPositionStrategy` is used. |position?, container?| | ||||||
| |createRelativeOverlaySettings| Creates overlay settings with auto, connected or elastic position strategy based on a preset position settings |target, strategy?, position?| | ||||||
|
|
||||||
|
|
||||||
|
|
||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the new
IgxOverlayService.createAbsoluteOverlaySettingscan really be considered a new feature and thecontainerprop, though that's repalacing.The behavior change and deprecation fall under a different section (prob General).