test(test): assert if correct condition is recreated based on conditi…#16902
Open
hanastasov wants to merge 4 commits intomasterfrom
Open
test(test): assert if correct condition is recreated based on conditi…#16902hanastasov wants to merge 4 commits intomasterfrom
hanastasov wants to merge 4 commits intomasterfrom
Conversation
hanastasov
added
grid: state-persistence
filtering
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the extracted filter column state was incorrectly being set to "contains" instead of the actual selected condition when users changed filter conditions or restored grid state.
Changes:
- Prioritized
condition.nameoverconditionNamewhen recreating filter expressions to ensure the correct source of truth is used - Made
conditionNamealways sync withcondition.nameafter recreation, removing the conditional check - Added test coverage for the scenario where
conditionNameandcondition.nameare out of sync
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| projects/igniteui-angular/core/src/data-operations/expressions-tree-util.ts | Fixed priority order in recreateOperatorFromDataType and recreateExpression to use condition.name before conditionName; ensured conditionName is always synced with condition.name; exported recreateExpression function for testing |
| projects/igniteui-angular/core/src/data-operations/expressions-tree-util.spec.ts | Added test case to verify that expressions with mismatched conditionName and condition.name are correctly recreated with the proper conditionName |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
conditionNameis used to recreateexpression.conditionwhen restoring grid state from IgxGridState directive. Without this fix, restoring grid state would change condition from whatever it was to the default condition "contains"Solution:
condition.nameoverconditionNameconditionName = condition.nameCloses #16841
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)