feat(PDF): Adding customFont option for PDF exporter.
#16892
+530
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gedinakova
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds custom font support to the PDF exporter service, enabling Unicode character rendering beyond the default Helvetica font's basic Latin character set. This enhancement addresses the need for exporting data containing non-Latin scripts like Cyrillic, Chinese, Japanese, Arabic, and Hebrew characters.
Changes:
- Added
customFontproperty toIgxPdfExporterOptionswith support for Base64-encoded TrueType fonts - Implemented font registration logic with automatic fallback to Helvetica on errors
- Added comprehensive unit tests covering edge cases for custom font configuration
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pdf-exporter.ts | Implements custom font registration logic with validation and fallback handling |
| pdf-exporter.spec.ts | Adds comprehensive test coverage for custom font feature including edge cases |
| pdf-exporter-options.ts | Defines PdfUnicodeFont interface and adds customFont property with detailed documentation |
| CHANGELOG.md | Documents the new custom font feature with usage examples |
projects/igniteui-angular/grids/core/src/services/pdf/pdf-exporter.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/grids/core/src/services/pdf/pdf-exporter.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/grids/core/src/services/pdf/pdf-exporter.ts
Outdated
Show resolved
Hide resolved
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
…m/IgniteUI/igniteui-angular into gedinakova/pdf-custom-font-option
projects/igniteui-angular/grids/core/src/services/pdf/pdf-exporter.ts
Outdated
Show resolved
Hide resolved
…rter.ts Co-authored-by: Copilot <[email protected]>
…rter.ts Co-authored-by: Copilot <[email protected]>
…m/IgniteUI/igniteui-angular into gedinakova/pdf-custom-font-option
projects/igniteui-angular/grids/core/src/services/pdf/pdf-exporter.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/grids/core/src/services/pdf/pdf-exporter-options.ts
Outdated
Show resolved
Hide resolved
…rter-options.ts Co-authored-by: Copilot <[email protected]>
…rter.ts Co-authored-by: Copilot <[email protected]>
…rter.ts Co-authored-by: Copilot <[email protected]>
projects/igniteui-angular/grids/core/src/services/pdf/pdf-exporter.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/grids/core/src/services/pdf/pdf-exporter.spec.ts
Outdated
Show resolved
Hide resolved
…rter.ts Co-authored-by: Copilot <[email protected]>
projects/igniteui-angular/grids/core/src/services/pdf/pdf-exporter.spec.ts
Show resolved
Hide resolved
…rter.spec.ts Co-authored-by: Copilot <[email protected]>
projects/igniteui-angular/grids/core/src/services/pdf/pdf-exporter.spec.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16606
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)