Skip to content

Conversation

@IMinchev64
Copy link
Contributor

@IMinchev64 IMinchev64 commented Jan 21, 2026

Closes #16493

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@mddragnev
Copy link
Member

mddragnev commented Jan 29, 2026

@skrustev @IMinchev64 The change is fine. However, if the action strip is set as menu this behavior is not perfect IMO.
I think that when having the action strip as menu we should close the menu on every action click
https://github.com/user-attachments/assets/635939be-2a58-4f49-830e-0fa6898cc35a

@IMinchev64 IMinchev64 changed the title fix(grid-pinning): remove hide call in scrollToRow fix(grid-pinning): remove hide call in scrollToRow - master Jan 29, 2026
@IMinchev64
Copy link
Contributor Author

@mddragnev I added a condition to continue hiding the strip when the action strip is a menu.

Note that testing this in elements would be a bit of a hassle currently as:

  1. The fix for this issue ([Elements] igc-action-strip stays hidden / not visible #16834) would need to be merged in both master and 21.0.x as the action strip is broken in elements for the respective branches
  2. Even when the action strip works as a whole, using it as a menu is broken in elements as the moment we try to hover over the menu, the action strip gets hidden. This should be logged and fixed separately.

@mddragnev
Copy link
Member

The issue still reproduces when the record you try to scroll to is out of view

@IMinchev64
Copy link
Contributor Author

The issue still reproduces when the record you try to scroll to is out of view

I am failing to reproduce this scenario with the same result

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Elements] Action strip closes when clicking jump to row action

3 participants