feat(query-builder): Expose query builder component in elements#16731
Merged
feat(query-builder): Expose query builder component in elements#16731
Conversation
mddragnev
added
❌ status: awaiting-test
gedinakova
previously approved these changes
Jan 22, 2026
gedinakova
added
✅ status: verified
damyanpetev
reviewed
Jan 28, 2026
| parents: [], | ||
| contentQueries: [], | ||
| additionalProperties: [], | ||
| methods: ["canCommit", "commit", "discard", "onExpressionTreeChange"], |
Member
There was a problem hiding this comment.
@gedinakova @mddragnev I highly doubt onExpressionTreeChange is supposed to be a public method :) Not a big deal, but ideally mark as @hidden @internal or if it's just a template handler - protected?
| import { IgxQueryBuilderSearchValueTemplateDirective } from './query-builder.directives'; | ||
| import { IgxQueryBuilderSearchValueContext } from './query-builder.common'; | ||
|
|
||
| /* wcElementTag: igc-query-builder-header */ |
Member
There was a problem hiding this comment.
That selector should be
Suggested change
| /* wcElementTag: igc-query-builder-header */ | |
| /* wcElementTag: igc-query-builder */ |
?
Comment on lines
245
to
253
| /** | ||
| * @hidden | ||
| */ | ||
| public ngAfterContentInit(): void { | ||
| if (this.searchValueTemplateDirective) { | ||
| this._searchValueTemplate = this.searchValueTemplateDirective.template; | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Um, any specific reason to use ngAfterContentInit? It's rather rigid in assuming the directive is available at this time, rather that being added later.
Much prefer the grid getter pattern like:
public get searchValueTemplate(): TemplateRef<IgxQueryBuilderSearchValueContext> {
return this._searchValueTemplate || this.searchValueTemplateDirective?.template;
}or something like that
gedinakova
approved these changes
Jan 28, 2026
damyanpetev
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)