Fix the Path tool adding a Path node but not applying the change until a second attempt due to wrong segment IDs#3727
Merged
Keavon merged 3 commits intoGraphiteEditor:masterfrom Feb 13, 2026
Conversation
Contributor
Author
|
Hey , @0HyperCube . Can you review this one please, looks good to me |
0HyperCube
approved these changes
Feb 7, 2026
Contributor
0HyperCube
left a comment
0HyperCube
left a comment
There was a problem hiding this comment.
Seems like a reasonable fix; it seems to work well.
Ayush2k02
force-pushed
the
fix-segment-ids-without-path-node
branch
from
ba2513d to
762479a
Compare
Contributor
Author
|
Yup, all working after the recent rebase against master |
Keavon
force-pushed
the
fix-segment-ids-without-path-node
branch
from
762479a to
2e68666
Compare
Member
|
!build |
|
Keavon
changed the title
Keavon
approved these changes
Feb 13, 2026
Member
|
This also apparently fixes #2687 by accident. If you comment in that issue, I can assign it to you also. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-02-06.at.8.19.03.AM.mov
Closes #3481, closes #2687